timehop / apns

A Go package to interface with the Apple Push Notification Service
https://godoc.org/github.com/timehop/apns
MIT License
185 stars 47 forks source link

Timed out test #44

Open exklamationmark opened 9 years ago

exklamationmark commented 9 years ago

Hi,

When I ran the tests for https://github.com/timehop/apns/commit/135f56759da5d4da98054f1819bd2b3c1d1a51b0, I saw this

$ go test
Running Suite: Apns Suite
=========================
Random Seed: 1431423856
Will run 72 of 72 specs

••••••••••••••••••••••••••••••••••••••••••••
------------------------------
•... Timeout [1.000 seconds]
Client
/home/mark/workspace/src/apns/client_test.go:384
  #Send
  /home/mark/workspace/src/apns/client_test.go:383
    bad push
    /home/mark/workspace/src/apns/client_test.go:181
      should not return an error [It]
      /home/mark/workspace/src/apns/client_test.go:180

      Timed out

      /home/mark/workspace/src/apns/client_test.go:180
------------------------------
••
------------------------------
•... Timeout [1.000 seconds]
Client
/home/mark/workspace/src/apns/client_test.go:384
  #Send
  /home/mark/workspace/src/apns/client_test.go:383
    good, bad, good, requeue of last good
    /home/mark/workspace/src/apns/client_test.go:382
      should not return an error [It]
      /home/mark/workspace/src/apns/client_test.go:381

      Timed out

      /home/mark/workspace/src/apns/client_test.go:381
------------------------------
••••••••••••••••••••••••

Summarizing 2 Failures:

[Timeout...] Client #Send bad push [It] should not return an error 
/home/mark/workspace/src/apns/client_test.go:180

[Timeout...] Client #Send good, bad, good, requeue of last good [It] should not return an error 
/home/mark/workspace/src/apns/client_test.go:381

Ran 72 of 72 Specs in 5.489 seconds
FAIL! -- 70 Passed | 2 Failed | 0 Pending | 0 Skipped --- FAIL: TestApns (5.49s)
FAIL
exit status 1
FAIL    apns    6.554s

For the first case ("#Send -> bad push -> should not return an error), I guess it's because this line block: https://github.com/timehop/apns/blob/master/client_test.go#L169

It's probably something wrong with my setup. Have you seen this before?

nathany commented 9 years ago

It's not your setup, see #27 and #12.

This is fixed on the develop branch, but that branch isn't quite ready to move to master.