timehop / apns

A Go package to interface with the Apple Push Notification Service
https://godoc.org/github.com/timehop/apns
MIT License
185 stars 47 forks source link

New `BadgeNumber` struct to handle badging - an alternative to using an *int #59

Closed themartorana closed 9 years ago

themartorana commented 9 years ago

Related to #38 - you told me to do it so I did ;)

Has new BadgeNumber struct and methods, along with tests and an updated MarshalJSON method for type APS.

See #38 for reasoning.

themartorana commented 9 years ago

Closing and compressing all my bad work into one good commit.

taylortrimble commented 9 years ago

Done with my first pass of review- big thank you @themartorana!

themartorana commented 9 years ago

Good notes, all. I'll get them implemented and pushed. Thanks!

themartorana commented 8 years ago

This was moved to #60 - didn't realize these comments weren't there. In any case, I'm moving over there, and will implement the same suggestions.