Closed themartorana closed 9 years ago
Closing and compressing all my bad work into one good commit.
Done with my first pass of review- big thank you @themartorana!
Good notes, all. I'll get them implemented and pushed. Thanks!
This was moved to #60 - didn't realize these comments weren't there. In any case, I'm moving over there, and will implement the same suggestions.
Related to #38 - you told me to do it so I did ;)
Has new
BadgeNumber
struct and methods, along with tests and an updatedMarshalJSON
method for typeAPS
.See #38 for reasoning.