New `BadgeNumber` struct to handle badging - an alternative to using an *int

timehop / apns

A Go package to interface with the Apple Push Notification Service

https://godoc.org/github.com/timehop/apns

MIT License

185 stars 47 forks source link

New `BadgeNumber` struct to handle badging - an alternative to using an *int #60

Closed themartorana closed 8 years ago

themartorana commented 9 years ago

Apologies for the last PR. This one should do it.

See #38 for details.

themartorana commented 8 years ago

Suggestions from #59 implemented.

taylortrimble commented 8 years ago

2nd round of feedback in! I think this should be it... thank you! :smile:

themartorana commented 8 years ago

Ok, hopefully this should do it. Thanks!

taylortrimble commented 8 years ago

Okay, I like it! @nathany or @bdotdub have merge button privileges. Can one of you two look over the test cases more carefully (I don't really do that), and get this merged in? Looks great to me!

:peach:

nathany commented 8 years ago

Thanks @themartorana. The only thing that is missing is an update the example in the README.

themartorana commented 8 years ago

@nathany it's in the README: 2293a98 (diff)

Was there something more specific you wanted, maybe BadgeNumber having its own section in the README?

nathany commented 8 years ago

Sorry. I missed it when I was looking.

themartorana commented 8 years ago

:cool:

taylortrimble commented 8 years ago

Thank you @themartorana!