search

timehop / apns

A Go package to interface with the Apple Push Notification Service
https://godoc.org/github.com/timehop/apns
MIT License
185 stars 47 forks source link

Fix test failure: put assertions inside an It() #8

Closed nathany closed 9 years ago

nathany commented 9 years ago

If you're using Ginkgo then you probably forgot to put your assertion in an It().

nathany commented 9 years ago

There are still some timeout errors in the tests. If I log the error in runLoop() it appears to be a problem with the dummy certificate:

2014/11/26 12:16:11 remote error: unknown certificate authority
2014/11/26 12:16:11 dial tcp 127.0.0.1:50007: connection refused
2014/11/26 12:16:12 dial tcp 127.0.0.1:50008: connection refused
2014/11/26 12:16:12 dial tcp 127.0.0.1:50009: connection refused
2014/11/26 12:16:12 remote error: unknown certificate authority
2014/11/26 12:16:12 dial tcp 127.0.0.1:50007: connection refused
2014/11/26 12:16:13 remote error: unknown certificate authority
2014/11/26 12:16:13 dial tcp 127.0.0.1:50008: connection refused
bdotdub commented 9 years ago

Whoops 😁. Merging!

nathany commented 9 years ago

Thanks. Maybe Ginkgo changed something in a newer version to cause that, I don't know.

I'm still not sure about the certificate authority tests.