timehop / apns

A Go package to interface with the Apple Push Notification Service
https://godoc.org/github.com/timehop/apns
MIT License
185 stars 47 forks source link

Support Safari Push and Mobile Device Management #9

Closed nathany closed 9 years ago

nathany commented 9 years ago

Rounding out support different types push notifications:

This just allows these types of notifications through, it doesn't ensure that they are fully valid. I'm doing validations in advance.

bdotdub commented 9 years ago

Can we add a test case around this?

nathany commented 9 years ago

I'd like to. Still test failures on master though, even after #8. I'm new to Ginkgo.

nathany commented 9 years ago

@bdotdub I'm not sure how to fix the existing failing tests (#12), but I've now added tests for my additions.

nathany commented 9 years ago

I merged #14 into this. Once that's merged, I can rebase so that you can see just these changes.

bdotdub commented 9 years ago

Merging this!

nathany commented 9 years ago

Thanks!