Closed nathany closed 9 years ago
Can we add a test case around this?
I'd like to. Still test failures on master though, even after #8. I'm new to Ginkgo.
@bdotdub I'm not sure how to fix the existing failing tests (#12), but I've now added tests for my additions.
I merged #14 into this. Once that's merged, I can rebase so that you can see just these changes.
Merging this!
Thanks!
Rounding out support different types push notifications:
This just allows these types of notifications through, it doesn't ensure that they are fully valid. I'm doing validations in advance.