search

timelessco / chakra-components

Components built on top of Chakra UI
MIT License
1 stars 0 forks source link

[RFC] Base Components #1

Closed navin-moorthy closed 4 years ago

navin-moorthy commented 4 years ago

Introduction

I hope everyone has got an idea about what we are going to build with Chakra. As a starter, we will be building some base components from the next app that we are going to build. Later we will improve and evolve our component library.

List of Base Components

Rules

Action Items

List of things to be done,

I will edit the RFC and add further action items with PR number based on our comments.

prasanna1211 commented 4 years ago

@navin-moorthy List of components looks fine to me. I feel any of the components in design can be achieved by composing from these set. Can you sort them as per the difficulty so that we can create RFC one by one ?

navin-moorthy commented 4 years ago

@prasanna1211 I have made the changes, kindly check.

prasanna1211 commented 4 years ago

@govindsingh55 and @SamrithaS Have you verified this ? I would suggest you to confirm if these components are good enough for the start.

SamrithaS commented 4 years ago

yes I've verified it and its great

prasanna1211 commented 4 years ago

@navin-moorthy I think these four points should be rules rather than the Action Items itself.

prasanna1211 commented 4 years ago

Also Components should have checkbox rather than action items so that it is easy to identify which ones are completed. Also RFCs associated with it can be edited as and when we create one so that everything can be trackable from here.

govindsingh55 commented 4 years ago

these components are good to start.

navin-moorthy commented 4 years ago

@prasanna1211 Action Items will have the components step by step work instead of changing in the list with introduction.

prasanna1211 commented 4 years ago

I think it is better to add benchmarking libraries here. I would suggest PriceLine design system for its composability, Polaris shopify for the storybook

  1. So storybook will be the interface where we will be giving a demo of the components.
  2. We will create another repo for the example page that we are building and use this repo as the base components. (Through git submodules).

Any other benchmarks are fine too.

navin-moorthy commented 4 years ago

I will research on the other benchmark libraries in our free time. Since then we can follow PriceLine. @govindsingh55 @SamrithaS your thoughts on this?

prasanna1211 commented 4 years ago

@navin-moorthy Yes we can do that in individual component RFCs.

SamrithaS commented 4 years ago

@navin-moorthy yes, we can follow PriceLine

govindsingh55 commented 4 years ago

@navin-moorthy Priceline is Good.

prasanna1211 commented 4 years ago

Yes, but a bit old. Dot notation won't be available I think but we can adopt it.

prasanna1211 commented 4 years ago

@samritha Can you take text before button ? Since text is a dependency for button. @navin-moorthy can you change the order in the list ?

SamrithaS commented 4 years ago

sure, I'll do that

navin-moorthy commented 4 years ago

@prasanna1211 shall I work on Button? Since Box and Flex are related @govindsingh55 is working on it, your thoughts on this.

prasanna1211 commented 4 years ago

upto you people. Box, Flex, Button and Text is our initial set. Do as you wish.

prasanna1211 commented 4 years ago

If pull request is open for anything mention it in the RFC status. same for merging too.

prasanna1211 commented 4 years ago

Add more infra: Commitzen, All contributors

prasanna1211 commented 4 years ago

Guys Lets wrap this RFC with Button component. We will create a new RFC for the next set of components. @navin-moorthy @govindsingh55

navin-moorthy commented 4 years ago

Yeah, we can create new RFC with component centric and explained one.