search

timelessco / chakra-components

Components built on top of Chakra UI
MIT License
1 stars 0 forks source link

refactor(checkbox-component): example checkbox component with variant red #17

Closed navin-moorthy closed 4 years ago

navin-moorthy commented 4 years ago

Starter code to begin with Checkbox Component.

We can evolve from this based on our discussion.

prasanna1211 commented 4 years ago

but yes don't spread the props may be ? handle props one by one. If there are style props that are going to be common, keep it in a separate file and share it across.

navin-moorthy commented 4 years ago

but yes don't spread the props may be ? handle props one by one. If there are style props that are going to be common, keep it in a separate file and share it across.

Sure, but in this case we are not providing any props so the prop spreading can be removed. But show us an example on how to handle prop.

govindsingh55 commented 4 years ago

Only the default props that we want to define or different props than chakra needs ahould have condition.

navin-moorthy commented 4 years ago

Only the default props that we want to define or different props than chakra needs have condition.

Can you elaborate please? I don't get it.

prasanna1211 commented 4 years ago

Keep proceeding I will join once everything is completed from your side.

navin-moorthy commented 4 years ago

Last commit, looks fine, able to run and get the expected output image

navin-moorthy commented 4 years ago

Added custom font styles

navin-moorthy commented 4 years ago

Review this PR #17 and merge it @prasanna1211