search

timelessco / chakra-components

Components built on top of Chakra UI
MIT License
1 stars 0 forks source link

README.md, Package.json #19

Closed SamrithaS closed 4 years ago

SamrithaS commented 4 years ago

Readme.md and package.json changes

18

prasanna1211 commented 4 years ago

@SamrithaS Few things,

  1. first the PR should be to be to development
  2. Assign reviewer (must)
  3. You can see if it is mergable (without conflicts). If conflicts are there you might need to do a rebase (we can help you out initially)

@govindsingh55 Can you review and approve the PR (or feedbacks). Look changed files if everything is correct and includes whatever is there in #19

SamrithaS commented 4 years ago

@SamrithaS Few things,

  1. first the PR should be to be to development
  2. Assign reviewer (must)
  3. You can see if it is mergable (without conflicts). If conflicts are there you might need to do a rebase (we can help you out initially)

@govindsingh55 Can you review and approve the PR (or feedbacks). Look changed files if everything is correct and includes whatever is there in #19

A pr already exists from checkbox to development

govindsingh55 commented 4 years ago

@SamrithaS always checkout new branch from development if working on a completely new feature and raise PR to development. if the new feature is related to some branch then checkout from that branch and after finish raise PR to that particular parent branch.

govindsingh55 commented 4 years ago

@prasanna1211 @navin-moorthy do we need the react-boilerplate info in README.md

prasanna1211 commented 4 years ago

No. Only the details to install and start the project.