search

timelessco / chakra-components

Components built on top of Chakra UI
MIT License
1 stars 0 forks source link

[ComboBox] ListBox shouldn't have a close button #64

Open navin-moorthy opened 4 years ago

navin-moorthy commented 4 years ago

@prasanna1211 thinks list box shouldn't have close button.

image

Originally posted at issue

navin-moorthy commented 4 years ago

As per the standard there is no close button for combo-box, it's part of UX I guess. May we can make it hide with props if they don't want or by default it will be hidden and can have it with props

https://www.w3.org/TR/wai-aria-practices/examples/combobox/aria1.1pattern/listbox-combo.html

navin-moorthy commented 4 years ago

@prasanna1211 and @sandeepprabhakaran Do we need close button on the listbox? In my opinion, we can have it, or make it as prop to show or hide.

prasanna1211 commented 4 years ago

With props, yes I think.