search

timelesslounge / timelessis

35 stars 21 forks source link

#286 enable test_edit + remove puzzle #496

Open amihaiemil opened 5 years ago

amihaiemil commented 5 years ago

PR for #286

0crat commented 5 years ago

@amihaiemil/z this pull request is too small, just 5 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @emilianodellacasa/z please review this and merge or reject

emilianodellacasa commented 5 years ago

@amihaiemil There is a problem on Travis, the test you uncommented is failing

emilianodellacasa commented 5 years ago

@amihaiemil ping - the test is still not working, please check travis

amihaiemil commented 5 years ago

@emilianodellacasa As I see, the problem with form.save() was not fixed yet, otherwise the test should pass... but what I don't understand: why is there a secont test failing? See here (it's test test_sync_table from it_sync_tables_test.py -- these are different topics, I believe.

emilianodellacasa commented 5 years ago

@amihaiemil Maybe we should wait for #414 , actually you are right it is quite akward that other tests are failing when your code doesn't affect them

amihaiemil commented 5 years ago

@emilianodellacasa agree... I'm rather tight on time anyway :)