soin08 commented 5 years ago

316

Added a simple html form with the description field

codecov[bot] commented 5 years ago

Codecov Report

Merging #525 into master will increase coverage by 2.42%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #525      +/-   ##
==========================================
+ Coverage   87.91%   90.34%   +2.42%     
==========================================
  Files          55       55              
  Lines        1018     1025       +7     
  Branches       57       57              
==========================================
+ Hits          895      926      +31     
+ Misses        100       79      -21     
+ Partials       23       20       -3

Impacted Files	Coverage Δ
timeless/restaurants/table_shapes/views.py	`100% <ø> (ø)`	:arrow_up:
timeless/access_control/owner_privileges.py	`81.81% <0%> (-9.1%)`	:arrow_down:
timeless/employees/views.py	`92.59% <0%> (-0.27%)`	:arrow_down:
timeless/restaurants/tables/views.py	`100% <0%> (ø)`	:arrow_up:
timeless/restaurants/floors/forms.py	`100% <0%> (ø)`	:arrow_up:
timeless/roles/models.py	`96% <0%> (+0.34%)`	:arrow_up:
timeless/restaurants/floors/views.py	`87.09% <0%> (+1.91%)`	:arrow_up:
timeless/access_control/manager_privileges.py	`91.3% <0%> (+8.69%)`	:arrow_up:
timeless/customers/models.py	`95% <0%> (+14.04%)`	:arrow_up:
timeless/celery.py	`100% <0%> (+20%)`	:arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4ecff00...c17eaa2. Read the comment docs.

0crat commented 5 years ago

Job #525 is now in scope, role is REV

0crat commented 5 years ago

This pull request #525 is assigned to @vryazanov/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @emilianodellacasa/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

vryazanov commented 5 years ago

@rultor merge

rultor commented 5 years ago

@rultor merge

@vryazanov Thanks for your request. @emilianodellacasa Please confirm this.

emilianodellacasa commented 5 years ago

@soin08 where is the test for your code?

soin08 commented 5 years ago

@emilianodellacasa added the test

emilianodellacasa commented 5 years ago

@rultor merge

soin08 commented 5 years ago

@emilianodellacasa looks like merge didn’t work

rultor commented 5 years ago

@rultor merge

@emilianodellacasa OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 5 years ago

@rultor merge

@emilianodellacasa Done! FYI, the full log is here (took me 9min)

0crat commented 5 years ago

@ypshenychka/z please review this job completed by @vryazanov/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat commented 5 years ago

Job #525 is not in the agenda of @vryazanov/z, can't inspect

0crat commented 5 years ago

The job #525 is now out of scope

0crat commented 5 years ago

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @emilianodellacasa/z

ypshenychka commented 5 years ago

@vryazanov According to our QA Rules:

The code reviewer found at least three problems in the code. Comments were mostly about design problems, not cosmetic issues.

No issues were found during code review. Please confirm that you'll try to find at least three major problems while future reviews.

ypshenychka commented 5 years ago

@emilianodellacasa Please say "quality bad" here, when @vryazanov confirms

timelesslounge / timelessis

Adding HTML filter form for TableShape view #525

316

Codecov Report