vladarefiev commented 5 years ago

PR for https://github.com/timelesslounge/timelessis/issues/357:

created sort_query method in ListView
added test for that

codecov[bot] commented 5 years ago

Codecov Report

Merging #536 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #536   +/-   ##
=======================================
  Coverage   90.34%   90.34%           
=======================================
  Files          55       55           
  Lines        1025     1025           
  Branches       57       57           
=======================================
  Hits          926      926           
  Misses         79       79           
  Partials       20       20

Impacted Files	Coverage Δ
timeless/employees/views.py	`92.59% <ø> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1617f2c...5f863be. Read the comment docs.

0crat commented 5 years ago

Job #536 is now in scope, role is REV

0crat commented 5 years ago

Job gh:timelesslounge/timelessis#536 already assigned to @amihaiemil, can't assign to @vryazanov

0crat commented 5 years ago

This pull request #536 is assigned to @amihaiemil/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @emilianodellacasa/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

vladarefiev commented 5 years ago

@amihaiemil Pls see my questions, before I'm going to fix it.

vladarefiev commented 5 years ago

@amihaiemil I have just added a few tests, take a look. And still waiting your attention on my questions.

amihaiemil commented 5 years ago

@vladarefiev in principle, it's ok by me (maybe I didn't understand the task correctly?)

amihaiemil commented 5 years ago

@emilianodellacasa this is good to merge, from my point of view, but please have a look at our discussion in this PR :)

vladarefiev commented 5 years ago

@amihaiemil thanks for your review. @emilianodellacasa take a look pls.

vladarefiev commented 5 years ago

@emilianodellacasa done, pls have a look

emilianodellacasa commented 5 years ago

@rultor merge

rultor commented 5 years ago

@rultor merge

@emilianodellacasa OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 5 years ago

@rultor merge

@emilianodellacasa Done! FYI, the full log is here (took me 9min)

0crat commented 5 years ago

Job was finished in 37 hours, bonus for fast delivery is possible (see §36)

0crat commented 5 years ago

@ypshenychka/z please review this job completed by @amihaiemil/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat commented 5 years ago

Job #536 is not in the agenda of @amihaiemil/z, can't inspect

0crat commented 5 years ago

The job #536 is now out of scope

0crat commented 5 years ago

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @emilianodellacasa/z

vladarefiev commented 5 years ago

@ypshenychka ping

ypshenychka commented 5 years ago

@amihaiemil According to our QA Rules:

The code reviewer found at least three problems in the code. Comments were mostly about design problems, not cosmetic issues.

Only one issue was found during code review. Please confirm that you'll try to find at least three major problems while future reviews.

amihaiemil commented 5 years ago

@ypshenychka I confirm

ypshenychka commented 5 years ago

@emilianodellacasa Please say "quality acceptable" here

emilianodellacasa commented 5 years ago

@0crat quality acceptable

0crat commented 5 years ago

Order was finished, quality is "acceptable": +20 point(s) just awarded to @amihaiemil/z

0crat commented 5 years ago

Quality review completed: +4 point(s) just awarded to @emilianodellacasa/z

ypshenychka commented 5 years ago

@emilianodellacasa It's still in my agenda

timelesslounge / timelessis

#357: created order method for ListView #536

Codecov Report