timelesslounge / timelessis

37 stars 21 forks source link

For #297 Implement PropertyResource. #541

Open paulodamaso opened 5 years ago

paulodamaso commented 5 years ago

For #297 Implement PropertyResource.

0crat commented 5 years ago

Job #541 is now in scope, role is REV

0crat commented 5 years ago

This pull request #541 is assigned to @vryazanov/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @emilianodellacasa/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

vryazanov commented 5 years ago

@0crat refuse

0crat commented 5 years ago

@0crat refuse (here)

@vryazanov The user @vryazanov/z resigned from #541, please stop working. Reason for job resignation: Order was cancelled

0crat commented 5 years ago

Tasks refusal is discouraged, see §6: -15 point(s) just awarded to @vryazanov/z

0crat commented 5 years ago

This pull request #541 is assigned to @amihaiemil/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @emilianodellacasa/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

codecov[bot] commented 5 years ago

Codecov Report

Merging #541 into master will increase coverage by 0.02%. The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
+ Coverage   90.34%   90.36%   +0.02%     
==========================================
  Files          55       55              
  Lines        1025     1038      +13     
  Branches       57       58       +1     
==========================================
+ Hits          926      938      +12     
  Misses         79       79              
- Partials       20       21       +1
Impacted Files Coverage Δ
timeless/message/property_resource.py 88.23% <85.71%> (+13.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1617f2c...9fad347. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #541 into master will increase coverage by 0.19%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
+ Coverage   90.34%   90.54%   +0.19%     
==========================================
  Files          55       55              
  Lines        1025     1036      +11     
  Branches       57       57              
==========================================
+ Hits          926      938      +12     
+ Misses         79       78       -1     
  Partials       20       20
Impacted Files Coverage Δ
timeless/message/property_resource.py 100% <100%> (+25%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1617f2c...f52a9c1. Read the comment docs.

paulodamaso commented 5 years ago

@amihaiemil Corrections done and questions answered, please take a look

amihaiemil commented 5 years ago

@rultor good to merge

rultor commented 5 years ago

@rultor good to merge

@amihaiemil Thanks for your request. @emilianodellacasa Please confirm this.

0crat commented 5 years ago

@amihaiemil/z this job was assigned to you 22days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

zverovich commented 5 years ago

@0crat refuse

0crat commented 5 years ago

@zverovich/z I see that you unassigned this issue; the order is still assigned to @amihaiemil/z though; to cancel the order use refuse, as in §6

0crat commented 5 years ago

@0crat refuse (here)

@zverovich The user @amihaiemil/z resigned from #541, please stop working. Reason for job resignation: Order was cancelled