Open paulodamaso opened 5 years ago
This pull request #541 is assigned to @vryazanov/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @emilianodellacasa/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job
@0crat refuse
This pull request #541 is assigned to @amihaiemil/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @emilianodellacasa/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job
Merging #541 into master will increase coverage by
0.02%
. The diff coverage is85.71%
.
@@ Coverage Diff @@
## master #541 +/- ##
==========================================
+ Coverage 90.34% 90.36% +0.02%
==========================================
Files 55 55
Lines 1025 1038 +13
Branches 57 58 +1
==========================================
+ Hits 926 938 +12
Misses 79 79
- Partials 20 21 +1
Impacted Files | Coverage Δ | |
---|---|---|
timeless/message/property_resource.py | 88.23% <85.71%> (+13.23%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1617f2c...9fad347. Read the comment docs.
Merging #541 into master will increase coverage by
0.19%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #541 +/- ##
==========================================
+ Coverage 90.34% 90.54% +0.19%
==========================================
Files 55 55
Lines 1025 1036 +11
Branches 57 57
==========================================
+ Hits 926 938 +12
+ Misses 79 78 -1
Partials 20 20
Impacted Files | Coverage Δ | |
---|---|---|
timeless/message/property_resource.py | 100% <100%> (+25%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1617f2c...f52a9c1. Read the comment docs.
@amihaiemil Corrections done and questions answered, please take a look
@rultor good to merge
@rultor good to merge
@amihaiemil Thanks for your request. @emilianodellacasa Please confirm this.
@0crat refuse
For #297 Implement PropertyResource.