search

timelyportfolio / RBioFabric

An R implementation of the BioFabric network visualization tool
7 stars 1 forks source link

biofabric deploy on shinyapps.io #3

Open jas1 opened 5 years ago

jas1 commented 5 years ago

Hi thanks for such awsome port , really love how it works.

Now to the case, I made it through my shiny app with custom graph , it works awsome; nevertheless when trying to deploy to shinyapps.io I got error message with dependencies.

[2018-10-31T03:40:53.417081830+0000] Building R package: RBioFabric (0.4) /mnt/packages/build /mnt Warning in untar2(tarfile, files, list, exdir, restore_times) : skipping pax global extended headers

  • installing to library �/opt/R/3.5.1/lib/R/library�
  • installing source package �RBioFabric� ... R inst ** byte-compile and prepare package for lazy loading Error in loadNamespace(i, c(lib.loc, .libPaths()), versionCheck = vI[[i]]) : there is no package called �htmlwidgets� ERROR: lazy loading failed for package �RBioFabric�
  • removing �/opt/R/3.5.1/lib/R/library/RBioFabric�

tried explicitly importing "htmlwidgets" with no luck.

Searching a little more, have seen what might be similar issue on other package:

listviewer; and the solution PR: https://github.com/timelyportfolio/listviewer/pull/9

As i never built a package, but read what you have done on that one, my guess is that is missing:

Imports: htmlwidgets

on the DESCRIPTION file.

If thats the way i'll gladly help doing the fix and making a PR.

Again, thanks for such port, looking forward to your answer :D

Julio

jas1 commented 5 years ago

I've tried to see if worked, and forked : https://github.com/jas1/RBioFabric done the change : https://github.com/jas1/RBioFabric/commit/7ad013efbb6661079b4a9b780ddbc65828d8e35e pointed an example APP to my repo : https://github.com/jas1/RBioFabricShinyExample deployed on shinyapps.io: https://jaspa.shinyapps.io/RBioFabricShinyExample/ ( i'll shut down the app after is checked , as it consumes accont bandwidth )

and it worked :D

Nevertheless i used depends instead of imports, as you already used depends.

I prefer to put it to your repo as its " the RBioFabric " repo, so we keep tool consistency :)

if its ok / should be changed for any reason any feedback welcome. :)