search

timelyportfolio / rcdimple

htmlwidgets for rCharts + dimple
http://www.buildingwidgets.com/blog/2015/3/18/week-11-dimple-as-htmlwidget
MIT License
28 stars 9 forks source link

Possible problem PctAxis #8

Closed jpmarindiaz closed 9 years ago

jpmarindiaz commented 9 years ago

Hi! I am running examples 2 and 3 and they give the same result. I was expecting to see a normalized (100%) bar stacked bar chart in example 3. Any hints?

Example 2 screen shot 2015-04-03 at 8 15 17 pm

Example 3 screen shot 2015-04-03 at 8 15 25 pm

timelyportfolio commented 9 years ago

Example 3 should be equivalent to the 100% vertical stacked example from dimple. I'll check into it to see that nothing has changed to disrupt this. It was working fine earlier. Does the horizontal stacked 100% also not work?

timelyportfolio commented 9 years ago

@jpmarindiaz Thanks so much for finding this error that was introduced in b4a5615f00688c9144e97e54bdbc4a5d3752e6d7 . Somehow I missed it in my tests. I believe this should now be resolved in 97a4704cb3bd7f83f947a988c43965c223d9c676. Please let me know if it still does not work for you.

If you look carefully, you might notice there are two ways now to specify a percent axis, but the preferred and documented way is type="addPctAxis". For reference, the other way is to do type="addMeasureAxis", showPercent=T.

Also, happy you are trying it out. Would love feedback.

jpmarindiaz commented 9 years ago

@timelyportfolio Awesome! Thanks for fixing this so quickly. Great implementation, I will refactor my package to use yours. Cheers

timelyportfolio commented 9 years ago

I think we can close this. Happy to reopen if not complete.