Open Shians opened 6 years ago
@Shians thanks so much for the pull!!!! I am not sure how I missed it until now. I will review and submit feedback over the next couple of days.
@Shians thanks so much for the pull!!!! I am not sure how I missed it until now. I will review and submit feedback over the next couple of days.
Hi! Any advancement on the reviewal/submission process so far ? Thanks !
(In reference to #75)
percentMode = c("total", "parent")
to allow percentages and counts to be shown relative to the parent element rather than of the total."total"
, so results of existing function calls should be unchangedI'm not totally sure of the argument name, since it toggles both percent and count modes, but having a separate
percentMode
andcountMode
feels a bit clunky. Maybe can even incorporate this into the JS to toggle within the widget.Displaying total percentage:
Displaying percentage of parent: