search

timelyportfolio / vue-vega

vue and vega - experimental for now
https://timelyportfolio.github.io/vue-vega
MIT License
4 stars 0 forks source link

seek feedback from vega team #1

Open timelyportfolio opened 7 years ago

timelyportfolio commented 7 years ago

@domoritz I have started to assemble this Vue + Vega component based very loosely on @kristw react-vega as I attempt to integrate Vega in a Vue project. I know you are slam packed with far more important items, but I would absolutely love any feedback you might be able to provide specifically on lines.

Example

very basic gh-pages examples https://timelyportfolio.github.io/vue-vega

domoritz commented 7 years ago

Looks reasonable. I suggest that you look at https://github.com/vega/vega-embed and either copy the behavior we implemented there or even just use vega-embed instead of calling Vega yourself.

timelyportfolio commented 7 years ago

Thanks @domoritz I did look closely at vega-embed and even made a very simple Vue component using vega.embed. I can't remember why I ended up scrapping, but I think I wanted more control. I know "more control" probably means much higher likelihood of screwing up.

I will try to write some tests and add some error checking to figure out what I might have already messed up.

Also, off-topic, but I might be doing a whole lot of vega and vega-lite over the next couple of weeks, and I can't wait to try out all the amazing new stuff that y'all have added over the last months. I already tried to answer some StackOverflow today. Thanks!!!!

domoritz commented 7 years ago

Wohoo. (I should check SO more often...)