Add comments by employee and approver

[jekuno]

Expected: As an employee I can optionally enter a short comment why I request a leave (e.g. "Funeral grandma" or "Influenza" or "Hiking tour Norway"). The employee comment could then be displayed in the calendar team view feed of admins/approvers as well (which improves awareness for other team members in open minded teams). As an approver I can optionally enter a short comment as well (e.g. "Enjoy your holiday!" or "Sorry, too much workload right now. Shift your leave by two weeks if possible.")

Currently: Neither the employee nor the approver can add comments. However the DB table Leaves already has the fields employee_comment and approver_comment and the reason param already gets fetched in the sourcecode. So it should be pretty straightforward to implement.

[vpp]

Yeah, the storage part is done.

The problem was in how to render that data thats why it stuck.

Good point about this feature though.

[nnmalex]

I plus this request. That would be very useful.

[vpp]

One more person asked for this

[rody8808]

What about in the subject line of the email?

[vpp]

Hi @rody8808,

Can you please elaborate little bit more, as it is not very clear to me.

Thanks Pavlo

Sent from my iPhone

On 26 Apr 2017, at 18:15, rody8808 notifications@github.com wrote:

What about in the subject line of the email?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[rody8808]

With the extra field such as (reason) you could assign it to the subject line of the email sent to the supervisor.

From: Pavlo [mailto:notifications@github.com] Sent: Wednesday, April 26, 2017 11:24 AM To: timeoff-management/application application@noreply.github.com Cc: Mention mention@noreply.github.com Subject: Re: [timeoff-management/application] Add comments by employee and approver (#133)

Hi @rody8808,

Can you please elaborate little bit more, as it is not very clear to me.

Thanks Pavlo

Sent from my iPhone

On 26 Apr 2017, at 18:15, rody8808 notifications@github.com<mailto:notifications@github.com> wrote:

What about in the subject line of the email?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[vpp]

Ah I see...

Absolutely!

Thank you @rody8808 for suggestion.

(we need to bare in mind that any free text could be exploited by spammers, but in this case this is less likely to be an issue)

On 26 April 2017 at 18:27, rody8808 notifications@github.com wrote:

With the extra field such as (reason) you could assign it to the subject line of the email sent to the supervisor.

From: Pavlo [mailto:notifications@github.com] Sent: Wednesday, April 26, 2017 11:24 AM To: timeoff-management/application application@noreply.github.com Cc: Darren G. Brown darren@nhb.org; Mention mention@noreply.github.com

Subject: Re: [timeoff-management/application] Add comments by employee and approver (#133)

Hi @rody8808,

Can you please elaborate little bit more, as it is not very clear to me.

Thanks Pavlo

Sent from my iPhone

On 26 Apr 2017, at 18:15, rody8808 <notifications@github.com<mailto: notifications@github.com>> wrote:

What about in the subject line of the email?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense. proofpoint.com/v2/url?u=https-3A__github.com_timeoff- 2Dmanagement_application_issues_133-23issuecomment-2D297482675&d=DQMFaQ&c= euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=-eI1V-jnedK6EQUoTJuy9g&m= rcHyTz2WCQMubCwRybEYBg27lFvA4mXjV3u5K0upCC0&s=Tx98tw_ hHxymanY3Fin81XZzaKJs-FlG5oWIkjexPIw&e=, or mute the thread< https://urldefense.proofpoint.com/v2/url?u=https- 3A__github.com_notificationsunsubscribe-2Dauth AawrxjWS6n6z5JKknZv09MUyKUTS8SFHks5rz33AgaJpZM4Ms4Pl&d=DQMFaQ&c= euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=-eI1V-jnedK6EQUoTJuy9g&m= rcHyTz2WCQMubCwRybEYBg27lFvA4mXjV3u5K0upCC0&s= Zk8WJXSDWE8LpDlrpGMADtT8DqTqT7319aO5EurW3_8&e=>.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/timeoff-management/application/issues/133#issuecomment-297483659, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMbE5V1tkdC4WRGnCbZouftJ3g4-yCZks5rz36SgaJpZM4Ms4Pl .

[rody8808]

It looks like it may work better on our own server with all the tweaks we need. I will run it on hosted for the 30 days and get feedback from everyone.

Thanks Darren

From: Pavlo [mailto:notifications@github.com] Sent: Wednesday, April 26, 2017 11:54 AM To: timeoff-management/application application@noreply.github.com Cc: Darren G. Brown darren@nhb.org; Mention mention@noreply.github.com Subject: Re: [timeoff-management/application] Add comments by employee and approver (#133)

Ah I see...

Absolutely!

Thank you @rody8808 for suggestion.

(we need to bare in mind that any free text could be exploited by spammers, but in this case this is less likely to be an issue)

On 26 April 2017 at 18:27, rody8808 notifications@github.com<mailto:notifications@github.com> wrote:

With the extra field such as (reason) you could assign it to the subject line of the email sent to the supervisor.

From: Pavlo [mailto:notifications@github.com] Sent: Wednesday, April 26, 2017 11:24 AM To: timeoff-management/application application@noreply.github.com<mailto:application@noreply.github.com> Cc: Darren G. Brown darren@nhb.org<mailto:darren@nhb.org>; Mention mention@noreply.github.com<mailto:mention@noreply.github.com>

Subject: Re: [timeoff-management/application] Add comments by employee and approver (#133)

Hi @rody8808,

Can you please elaborate little bit more, as it is not very clear to me.

Thanks Pavlo

Sent from my iPhone

On 26 Apr 2017, at 18:15, rody8808 <notifications@github.com<mailto: mailto:notifications@github.com%3cmailto:%0b> notifications@github.commailto:notifications@github.com>> wrote:

What about in the subject line of the email?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense. <https://urldefense.%0b> proofpoint.com/v2/url?u=https-3Agithub.com_timeoff- 2Dmanagement_application_issues_133-23issuecomment-2D297482675&d=DQMFaQ&c= euGZstcaTDllvimEN8b7jXrwqOf-v5ACdpgnVfiiMM&r=-eI1V-jnedK6EQUoTJuy9g&m= rcHyTz2WCQMubCwRybEYBg27lFvA4mXjV3u5K0upCC0&s=Tx98tw hHxymanY3Fin81XZzaKJs-FlG5oWIkjexPIw&e=>, or mute the thread< https://urldefense.proofpoint.com/v2/url?u=https- 3Agithub.com_notificationsunsubscribe-2Dauth AawrxjWS6n6z5JKknZv09MUyKUTS8SFHks5rz33AgaJpZM4Ms4Pl&d=DQMFaQ&c= euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=-eI1V-jnedK6EQUoTJuy9g&m= rcHyTz2WCQMubCwRybEYBg27lFvA4mXjV3u5K0upCC0&s= Zk8WJXSDWE8LpDlrpGMADtT8DqTqT7319aO5EurW3_8&e=>.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/timeoff-management/application/issues/133#issuecomment-297483659, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMbE5V1tkdC4WRGnCbZouftJ3g4-yCZks5rz36SgaJpZM4Ms4Pl .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_timeoff-2Dmanagement_application_issues_133-23issuecomment-2D297490879&d=DQMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=-eI1V-jnedK6EQUoTJuy9g&m=4DDa4tyr8DaOohHEUni8ytp5rplKwI0Z-936-D2SQiY&s=9xfaoDkNW01Ff9tYFZ_dNRQzygtCnxY03Jq_W-3-Hk0&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_Aawrxp2gdwVl2m9522I94GbCHn-5F91ccdks5rz4S2gaJpZM4Ms4Pl&d=DQMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=-eI1V-jnedK6EQUoTJuy9g&m=4DDa4tyr8DaOohHEUni8ytp5rplKwI0Z-936-D2SQiY&s=ZS0X8nRyyA5yv_BbeGdXB9NX3aXYvRezT7zCLA4oZvA&e=.

[mladenmilev]

I agree comments on requests and also upon approval and rejection is nice feature. For example rejecting holidays and adding explanation "Due to project delay agreed holidays to be taken next year" will help both Manager and Employee not forget and reschedule for next year. Real customer sutuation.

[net-architect]

I second this... please can you add the feature / will this be implemented soon?

Thanks Mark

[theapprover]

how is this one coming along? I am interested in being able to use this feature as well.

[vpp]

Hi, did not get any progress since last comment unfortunately.

Thank you for casting vote: it will bump priority up

Sent from my iPhone

On 1 Nov 2017, at 12:37, theapprover notifications@github.com wrote:

how is this one coming along? I am interested in being able to use this feature as well.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[vpp]

+1

[ktaranek]

Badly needed feature. +1

[sergiocontrino]

i second this: (requestor) comment on the mouseover hint in the team view would be good for me.

[vinaych7]

very interesting feature! :) just wondering if there is any update on this?