search

timer-machine / timer-machine-android

⏲ A highly customizable interval timer app for Android
GNU General Public License v3.0
172 stars 16 forks source link

statistics for timer starting on one day and ending another inconsistent #55

Open Emilv2 opened 9 months ago

Emilv2 commented 9 months ago

Screenshot_2023-09-13-18-22-32-03_8f43e9927574d4d5ed1228b7559896c8_1 Screenshot_2023-09-13-18-22-36-25_8f43e9927574d4d5ed1228b7559896c8_1

The dots on the calendar show timers ended on that day, but the list below shows timers started on that day. I'm not sure which one is the best way, but I'd say it should at least be consistent.

DeweyReed commented 9 months ago

The list below shows the start time and end time. When an event starts in one day and ends on the second day, the app considers it an event on the second day. The event in your screenshot began at 22:32 on 10th August and ended at 4:54 on 11th.

Emilv2 commented 9 months ago

In that case I would say the bug is in the "dots view" on top: There is no blue dot on the 11th although there's a timer ending on that day. There are 3 dots on the 10th, but only 2 events end on the 10th. Screenshot_2023-09-13-18-22-36-25_8f43e9927574d4d5ed1228b7559896c8_1_1

DeweyReed commented 9 months ago

You're right about the bug. Thank you!

The app calculates the dots in the calendar by the start time of timers but calculates the events in a day by the end time of timers.

I'm going to calculate everything by the end time. Is there anything that I still need to consider?

Emilv2 commented 9 months ago

Thanks!

Since you're asking, maybe a way to have timers ending close after midnight count for the previous day. Something like this setting in Ankidroid: Screenshot_2023-09-23-13-46-39-33_a9eef3a2a561b80d5c76daebd0f9a14c

But it would just be a small cosmetic improvement, nothing super important to me.

DeweyReed commented 9 months ago

The setting to set the start of a day is helpful to those who end their day after midnight. I'll see what I can do. Thank you!