search

timescale / helm-charts

Configuration and Documentation to run TimescaleDB in your Kubernetes cluster
Apache License 2.0
264 stars 223 forks source link

timescaledb-single: simplify metrics gathering #438

Closed paulfantom closed 2 years ago

paulfantom commented 2 years ago

What this PR does / why we need it

Due to how SVC is named it can easily lead to conflicts. To solve this we had two choices: 1) rename it 2) remove it

I opted for the second option as it simplifies deployment. As a side effect, we need to switch from ServiceMonitor to PodMonitor, a change that shouldn't be affecting metrics gathering.

Additionally, removal of an SVC can be beneficial in large-scale deployments due to how kube-proxy works.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer

The issue was spotted while trying to figure out issues in https://github.com/timescale/tobs/pull/566

Checklist

onprem commented 2 years ago

Looks like the CI is failing because the podMonitor field is at different lines in the PR vs CI generated.