Removed -pg-version 11 from timescaledb-tune command

timescale / helm-charts

Configuration and Documentation to run TimescaleDB in your Kubernetes cluster

Apache License 2.0

264 stars 223 forks source link

Removed -pg-version 11 from timescaledb-tune command #448

Closed agronholm closed 2 years ago

agronholm commented 2 years ago

What this PR does / why we need it

The chart is set to always tune the settings for a specific PostgreSQL version (11) rather than the one actually being used. I am not certain what this will change in practice, but it does seem wrong to do so when there is no good reason.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #294

Special notes for your reviewer

Checklist

[X] Chart Version bumped
[x] CLA signed

paulfantom commented 2 years ago

Could you rebase and bump chart version?

agronholm commented 2 years ago

Could you rebase and bump chart version?

Sure. I just don't understand why every PR should increment the chart version. Isn't that a problem when you merge multiple PRs?

paulfantom commented 2 years ago

Yes, it is a small problem, but it is a tradeoff we are willing to go with. The requirement of bumping chart version with each PR allows us to move faster while reducing maintenance burden. This is a common pattern in helm chart development and it is also a default option when using helm chart test toolkit.

agronholm commented 2 years ago

Done.