timescale / helm-charts

Configuration and Documentation to run TimescaleDB in your Kubernetes cluster
Apache License 2.0
264 stars 223 forks source link

charts/timescaledb-single: simplify name override #526

Closed paulfantom closed 1 year ago

paulfantom commented 1 year ago

Signed-off-by: Paweł Krupa (paulfantom) pawel@krupa.net.pl

What this PR does / why we need it

This is simplifying the codebase a bit and aligns it with the defacto helm standard of using fullnameOverride setting. It is also explicitly stating what the name should look like by using {{ .Release.Name }}-timescaledb as a default value for fullnameOverride.

Additionally since fullnameOverride accepts now templated string, we can use it in tobs for better marking of different components.

I ran helm template before and after this change and it resulted in no changes (apart from auto-generated stuff).

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer

Checklist