Closed alejandrodnm closed 1 year ago
You'd need to bump the chart version though, for how our CI works.
@onprem do I need to bump the chart version just for this change?
@alejandrodnm Yes, we have CD setup to release a new version of chart with every PR, if there any changes in it's files. Since the README file is under the chart directory, we need to bump the version. Here we can just do a patch release.
@onprem the errors are related to a fix for the alerts that was made in this PR https://github.com/timescale/promscale/pull/1794 Is there something else I need to do?
I'll leave this open until the alerts are fixed on another PR
I have created #541 for the alerts. And these checks are unrelated and not required for this PR so I am going ahead and merging. Thanks!
Signed-off-by: alejandrodnm alejandrodnm@gmail.com
What this PR does / why we need it
Which issue this PR fixes
Special notes for your reviewer
Checklist