search

timescale / helm-charts

Configuration and Documentation to run TimescaleDB in your Kubernetes cluster
Apache License 2.0
264 stars 223 forks source link

WARN: environment contains invalid option 'backup-enabled' #544

Open mindrunner opened 1 year ago

mindrunner commented 1 year ago

I see a lot of those warnings in my logs:

Sourcing /home/postgres/.pgbackrest_environment                                                                                                                                                                                                                                                                                                                                         
WARN: environment contains invalid option 'backup-enabled'                                                                                                                                                                                                                                                                                                                              
Sourcing /home/postgres/.pgbackrest_environment                                                                                                                                                                                                                                                                                                                                         
WARN: environment contains invalid option 'backup-enabled'                                                                                                                                                                                                                                                                                                                              
Sourcing /home/postgres/.pgbackrest_environment                                                                                                                                                                                                                                                                                                                                         
WARN: environment contains invalid option 'backup-enabled'                                                                                                                                                                                                                                                                                                                              
Sourcing /home/postgres/.pgbackrest_environment                                                                                                                                                                                                                                                                                                                                         
WARN: environment contains invalid option 'backup-enabled'                                                                                                                                                                                                                                                                                                                              
Sourcing /home/postgres/.pgbackrest_environment                                                                                                                                                                                                                                                                                                                                         
WARN: environment contains invalid option 'backup-enabled'

It seems like helm chart is setting some environment whicht pgbackrest tries to parse. Similar to https://github.com/pgbackrest/pgbackrest/issues/799

Is that intended? Do I miss some configuration?

davidandreoletti commented 1 year ago

@mindrunner This is a non issue, caused by PGBACKREST_BACKUP_ENABLED set by the chart and pgbackrest having no support for a 'backup-enabled' setting.

mindrunner commented 1 year ago

Well, it's pretty verbose in my logs. Feels really not necessary to use a variable name which is sort of reserved by another application in the same stack. I mean, warnings are there for a reason, aren't they. Would a PR changing this variable be accepted?

davidandreoletti commented 1 year ago

Your suggestion seems like a reasonable fix it. Best to confirm with maintainers.

jleni commented 1 year ago

I would like to fix this. @nhudson @paulfantom Is this something I can start with?

nhudson commented 1 year ago

@jleni please if you can, create a PR and I will review when I can.

mshivanna commented 1 year ago

is there any update on this ticket? thank you