Proper Helm Labels - Githubissues

timescale / helm-charts

Configuration and Documentation to run TimescaleDB in your Kubernetes cluster

Apache License 2.0

261 stars 223 forks source link

Proper Helm Labels #572

Closed mmogylenko closed 1 year ago

mmogylenko commented 1 year ago

What this PR does / why we need it

This PR is sets proper Helm Labels, as described here: https://helm.sh/docs/chart_best_practices/labels/#standard-labels

Which issue this PR fixes

Fixes #241
... and many others

Special notes for your reviewer

Example of error:

Unable to continue with install: Service "db-config" in namespace "default" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"

Checklist

[x] Chart Version bumped
[x] CLA signed

sbrother commented 1 year ago

Why was this closed? It seems that this is still necessary.

sbrother commented 1 year ago

Ah, because this PR doesn't actually solve the problem.