timescale / helm-charts

Configuration and Documentation to run TimescaleDB in your Kubernetes cluster
Apache License 2.0
263 stars 223 forks source link

Incompatibility introduced by v0.27 #576

Open ignatiusreza opened 1 year ago

ignatiusreza commented 1 year ago

What happened?

The upgrade guide for Upgrading to 0.27 mention

This release removes nameOverride field from values.yaml in favor of fullnameOverride. If you were using nameOverride field, please update your values file to use the new field.

Which seems to indicate that no manual action need to be done for those who were not using nameOverride.

But this is not the case, since the output of "timescaledb.fullname" change from {{ .Release.Name }}-timescaledb to {{ .Release.Name }}. Which makes the upgrade open to data lost, since new PVC will be scheduled to be created with the new name.

Did you expect to see something different?

The resolved "timescaledb.fullname" should not changed. This can be done by changing the default value for fullnameOverride from {{ .Release.Name }} to {{ .Release.Name }}-timescaledb. and clusterName to {{ .Release.Name }}.

Alternatively, update the "Upgrading to 0.27" guide to mention that the following configuration MUST be provided to allow seamless upgrade with no data lost.

clusterName: '{{ .Release.Name }}'
fullnameOverride: '{{ .Release.Name }}-timescaledb'

How to reproduce it (as minimally and precisely as possible):

Environment

Anything else we need to know?: