Upgrade to pgx 0.5.4 - Githubissues

timescale / promscale_extension

[DEPRECATED] Tables, types and functions supporting Promscale

Other

37 stars 17 forks source link

Upgrade to pgx 0.5.4 #523

Closed JamesGuthrie closed 2 years ago

JamesGuthrie commented 2 years ago

Description

Waiting on PR to be merged upstream 1.

Merge requirements

Please take into account the following non-code changes that you may need to make with your PR:

[ ] CHANGELOG entry for user-facing changes
[ ] Updated the relevant documentation

sumerman commented 2 years ago

Not entirely sure all cases should go over to TimestampWithTimeZone, actually, but I'll let you be the judge.

Thank you @workingjubilee! AFAICT they all should.

sumerman commented 2 years ago

Not entirely sure all cases should go over to TimestampWithTimeZone, actually, but I'll let you be the judge.

Thank you @workingjubilee! AFAICT they all should.

Unfortunately, I'll have to revert this. Even though, semantically, it seems like something we'd want, I couldn't find a way to perform arithmetic ops on TimestampWithTimeZone: its internal field is private, and it doesn't implement Add