Docker image versioning for releases

timescale / timescaledb-docker-ha

Create Docker images containing TimescaleDB, Patroni to be used by developers and Kubernetes.

Apache License 2.0

143 stars 38 forks source link

Docker image versioning for releases #457

Open suikast42 opened 2 months ago

suikast42 commented 2 months ago

It seems so that all release versions like 16.2-ts2.14.2-all is updaeting with every built

https://hub.docker.com/r/timescale/timescaledb-ha/tags?page=&page_size=&ordering=&name=pg16.2-ts2.14.2

Is that a bug or did I miss something?

graveland commented 2 months ago

This repo builds on a schedule in order to incorporate upstream bug and security fixes, so this is expected.

suikast42 commented 2 months ago

And what is the correct way to use releases of this repo ? Should I always have to build it myself from tags for havin stable releases ?

graveland commented 2 months ago

You pick the level of comfort for changes that you're at:

pg16: pg minor versions and tsdb versions might update, along with system/pgdg things
pg16.2-ts2.14: the only thing that could change is the patch level of tsdb, and system/pgdg things
pg16.2-ts2.14.2: the only things that can change are system dependencies (and pgdg-packaged extensions can change too)

If you don't want anything to change, then you'd pin to a specific sha: timescale/timescaledb-ha@sha256:082aebfbb1cb03016f489e0dea845fd7db06b7ec3271b9b0c5ee44ef47e04c75

suikast42 commented 2 months ago

Interesting approach. But that's not the state of art to work with docker images. Why not use latest tag for the latest build ?

graveland commented 2 months ago

Generally speaking, using latest is frowned upon when actually deploying things as you're supposed to pick something more explicit so you don't get surprised by changes. Also, we build multiple different types of images (oss, and all for example), so just latest would be too ambiguous. We could add -latest to all of our existing tags, but that would just explode the number of tags and I don't think it would add a lot to disambiguate things?

suikast42 commented 2 months ago

... tags and I don't think it would add a lot to disambiguate things?

Not realy.

Look at https://hub.docker.com/r/timescale/timescaledb