search

timescale / timescaledb-docker

Release Docker builds of TimescaleDB
Apache License 2.0
290 stars 128 forks source link

Typo regarding Dockerfile command #232

Closed akashagarwal7 closed 7 months ago

akashagarwal7 commented 7 months ago

Hi all. I was going through the Dockerfile and noticed an apparent discrepancy in the following line: https://github.com/timescale/timescaledb-docker/blob/ddd1609e1bb6f0431f04eb3dbc23486c42537cb9/Dockerfile#L25

Shouldn't the rm -f $(ls -1 $(pg_config --pkglibdir)/timescaledb-*.so... bit be rm -f $(ls -1 $(pg_config --pkglibdir)/timescaledb-1*.so... instead, and hence matching the if condition?

jnidzwetzki commented 7 months ago

Hello @kashagarwal7,

Thanks for making us aware of this problem. I have opened a PR (https://github.com/timescale/timescaledb-docker/pull/233) that will fix the deletion logic.

akashagarwal7 commented 7 months ago

@jnidzwetzki I saw the commits. Thanks for the quick turnaround on this :)