search

timescale / timescaledb-docker

Release Docker builds of TimescaleDB
Apache License 2.0
290 stars 128 forks source link

Unify old TSDB version cleanup code #233

Closed jnidzwetzki closed 7 months ago

jnidzwetzki commented 7 months ago

Removed dead code to delete version 1.x TSDB versions and keep old versions in the Bitnami image.

Fixes: #232

jnidzwetzki commented 7 months ago

@svenklemm I am not sure if I get your point entirely. The new code restricts the copied TSDB versions to 5 (we do the same in the Bitnami image). Do you think we should remove this step? In this case, the image would become larger with every version.

svenklemm commented 7 months ago

Only deleting stuff from the 1.0 series was intentional afair. Image size is limited by pg version support with older versions having bigger images. Having all versions available is a plus as you might need it when using an old database that has not yet been updated.

jnidzwetzki commented 7 months ago

@svenklemm I reverted my changes and removed only the dead code. I also adjusted the bitnami image and applied the same logic to keep the old versions.