search

timescale / timescaledb-extras

Helper functions and procedures for timescale
Other
44 stars 16 forks source link

On conflict with conflict target #17

Open mglonnro opened 3 years ago

mglonnro commented 3 years ago

Cheers,

I read the earlier discussion about on conflict do update with a missing primary key (gives error). I made this simple change to make this work in my own project. Just a simple transport for whatever conflict target I want to be included in the statement.

What is your thinking about this? I'd be happy to make a pull request unless you're going down some other route to solve the problem.

https://github.com/timescale/timescaledb-extras/commit/dfc98d090099add9faeffafc30763e1b870e18ea

DavidPavlicek commented 3 years ago

Definitely need to be rectified in master... I'm OK with your solution.

mglonnro commented 3 years ago

Definitely need to be rectified in master... I'm OK with your solution.

Pull request #18 there now :)

branchvincent commented 3 years ago

i just ran into this as well, would be great to get #18 merged!