Closed fabriziomello closed 4 months ago
Attention: Patch coverage is 68.75000%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 80.87%. Comparing base (
59f50f2
) to head (92a6e19
). Report is 162 commits behind head on main.:exclamation: Current head 92a6e19 differs from pull request most recent head 38e5c2b
Please upload reports for the commit 38e5c2b to get more accurate results.
Files | Patch % | Lines |
---|---|---|
tsl/src/continuous_aggs/repair.c | 68.75% | 1 Missing and 4 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
In #6624 we refactored time_bucket catalog table to be more generic and introduced the
cagg_get_bucket_function
to inspect the query tree of a given Continuous Aggregate and return the time_bucket function oid.The problem with the implementation is we traverse the whole query tree looking for
FuncExpr
and in certain cases we can have two differenttime_bucket
function definition but what matters is the correct and validtime_bucket
function that is part of theQuery->groupClause
.Fixed it by inspecting only the
Query->groupClause
items looking for a valid time bucketFuncExpr
and return itOid
.Disable-check: force-changelog-file