search

timescale / timescaledb

An open-source time-series SQL database optimized for fast ingest and complex queries. Packaged as a PostgreSQL extension.
https://www.timescale.com/
Other
17.61k stars 883 forks source link

Add missed changelog message for COPY segfault fix #6947

Closed akuzm closed 4 months ago

akuzm commented 4 months ago

We didn't have changelog check in the required ones, I added it now.

Fixes #6540

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.70%. Comparing base (59f50f2) to head (7d6cd18). Report is 174 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6947 +/- ## ========================================== + Coverage 80.06% 81.70% +1.63% ========================================== Files 190 198 +8 Lines 37181 36851 -330 Branches 9450 9632 +182 ========================================== + Hits 29770 30110 +340 + Misses 2997 2866 -131 + Partials 4414 3875 -539 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

svenklemm commented 4 months ago

How did this pass CI? Did we remove the requirement for changelog entries?

It's not required atm not sure when it was turned off.

akuzm commented 4 months ago

How did this pass CI? Did we remove the requirement for changelog entries?

Yeah, for some reason the check was not in the required checks, I added it back in the branch protection settings https://github.com/timescale/timescaledb/settings/branch_protection_rules/799421