search

timescale / timescaledb

An open-source time-series SQL database optimized for fast ingest and complex queries. Packaged as a PostgreSQL extension.
https://www.timescale.com/
Other
17.61k stars 883 forks source link

Re-enable compressed OR boolexpr pushdown #6948

Closed akuzm closed 4 months ago

akuzm commented 4 months ago

To fix the original problem, it is enough to call eval_const_expressions() to normalize the nested AND boolexprs.

This is a follow-up to #6917

Disable-check: force-changelog-file

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.65%. Comparing base (59f50f2) to head (0577aa0). Report is 175 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6948 +/- ## ========================================== + Coverage 80.06% 81.65% +1.58% ========================================== Files 190 198 +8 Lines 37181 36849 -332 Branches 9450 9631 +181 ========================================== + Hits 29770 30089 +319 + Misses 2997 2882 -115 + Partials 4414 3878 -536 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fabriziomello commented 4 months ago

@akuzm should we backport it to 2.15.x?

svenklemm commented 4 months ago

@akuzm should we backport it to 2.15.x?

This is only needed if #6917 is also in 2.15.x

svenklemm commented 4 months ago

@akuzm should we backport it to 2.15.x?

This is only needed if #6917 is also in 2.15.x

Oh this needs to go into 2.15.x probably together with #6917 for the test changes

fabriziomello commented 4 months ago

@akuzm should we backport it to 2.15.x?

This is only needed if #6917 is also in 2.15.x

Oh this needs to go into 2.15.x probably together with #6917 for the test changes

Ok, backporting #6917 to 2.15.x