search

timescale / timescaledb

An open-source time-series SQL database optimized for fast ingest and complex queries. Packaged as a PostgreSQL extension.
https://www.timescale.com/
Other
16.83k stars 852 forks source link

Add pg_upgrade test to CI #6951

Closed fabriziomello closed 1 month ago

fabriziomello commented 1 month ago

It's long we need to have binary upgrade tests in our CI. One example is https://github.com/timescale/timescaledb/issues/6935 (and others) that can be prevented if we have such kind of test in our CI.

To implement the pg_upgrade test we used the python Testing Framework for PostgreSQL (https://github.com/postgrespro/testgres).

Unfortunately the testing framework don't have the ability to retain the pg_upgrade log files after a successful execution, then we created a PR to make it possible and we'll use this patched version until we get the code merged and released on upstream.

postgrespro/testgres#125

Closes #3868 #4428

Disable-check: force-changelog-file

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.68%. Comparing base (59f50f2) to head (3adbab2). Report is 178 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6951 +/- ## ========================================== + Coverage 80.06% 81.68% +1.61% ========================================== Files 190 198 +8 Lines 37181 36849 -332 Branches 9450 9631 +181 ========================================== + Hits 29770 30099 +329 + Misses 2997 2872 -125 + Partials 4414 3878 -536 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

svenklemm commented 1 month ago

LGTM