search

timescale / timescaledb

An open-source time-series SQL database optimized for fast ingest and complex queries. Packaged as a PostgreSQL extension.
https://www.timescale.com/
Other
16.83k stars 852 forks source link

Fix segfault creating CAgg on hypertable by hash #6981

Closed fabriziomello closed 1 month ago

fabriziomello commented 1 month ago

The new hypertable API allows create it with primary space partition and CAggs doesn't support hypertables with custom partition functions.

Fixed the segfault by properly checking if there are an open dimension available during the validation.

Disable-check: force-changelog-file

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.74%. Comparing base (59f50f2) to head (a5d846c). Report is 199 commits behind head on main.

Files Patch % Lines
tsl/src/continuous_aggs/common.c 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6981 +/- ## ========================================== + Coverage 80.06% 81.74% +1.68% ========================================== Files 190 199 +9 Lines 37181 37015 -166 Branches 9450 9673 +223 ========================================== + Hits 29770 30259 +489 + Misses 2997 2862 -135 + Partials 4414 3894 -520 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.