timescale / timescaledb

An open-source time-series SQL database optimized for fast ingest and complex queries. Packaged as a PostgreSQL extension.
https://www.timescale.com/
Other
16.83k stars 852 forks source link

Fix show_chunks on hypertable by hash #6984

Closed fabriziomello closed 1 month ago

fabriziomello commented 1 month ago

Using the new hypertable API creating closed dimentions when partitioning by hash was leading to a segfault on show_chunks.

Fixed it by checking for the closed primary dimension and erroring out in case of using parameters older_than and newer_than.

Disable-check: force-changelog-file

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.74%. Comparing base (59f50f2) to head (ee88a5c). Report is 202 commits behind head on main.

Files Patch % Lines
src/chunk.c 28.57% 2 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6984 +/- ## ========================================== + Coverage 80.06% 81.74% +1.68% ========================================== Files 190 199 +9 Lines 37181 37026 -155 Branches 9450 9680 +230 ========================================== + Hits 29770 30268 +498 + Misses 2997 2863 -134 + Partials 4414 3895 -519 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.