Open mkindahl opened 1 month ago
Attention: Patch coverage is 88.46154%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 81.79%. Comparing base (
59f50f2
) to head (d9ad469
). Report is 243 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/process_utility.c | 88.46% | 1 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please add a test for reassigning to postgres.
Please add a test for reassigning to postgres.
I assume you mean a user with SUPERUSER privileges: we do not have the "postgres" user in the test suite.
Please add a test for reassigning to postgres.
I updated it with a test that assigning the job to a different owner does not work unless you've got superuser privileges.
Don't think this is how we want it to work since an administrator should be able to reassign jobs without having superuser privileges.
Please add a test for reassigning to postgres.
I updated it with a test that assigning the job to a different owner does not work unless you've got superuser privileges.
Don't think this is how we want it to work since an administrator should be able to reassign jobs without having superuser privileges.
I wanted to see that it doesnt work, anything else would be a security vulnerability.
Please add a test for reassigning to postgres.
I updated it with a test that assigning the job to a different owner does not work unless you've got superuser privileges. Don't think this is how we want it to work since an administrator should be able to reassign jobs without having superuser privileges.
I wanted to see that it doesnt work, anything else would be a security vulnerability.
Yes, obviously, but in this form it is also a usability issue.
I am not sure how to have some sort of administrative user that does not have "superuser" privileges but still can run a "reassigned owned by" in a limited fashion. Not even sure it is possible to define a "safe" rule for this. Something we need to think about.
Using
REASSIGN OWNED BY
for background jobs do not work because it does not change the owner of the job. This commit fixes this by capturing the utility command and makes the necessary changes to thebgw_job
table.It also factors out background jobs DDL tests into a separate file.