timescale / timescaledb

An open-source time-series SQL database optimized for fast ingest and complex queries. Packaged as a PostgreSQL extension.
https://www.timescale.com/
Other
16.82k stars 852 forks source link

Backport to 2.15.x: #7005: Allow CAggs with variable sized bucked with origin/offset #7011

Closed fabriziomello closed 3 weeks ago

fabriziomello commented 4 weeks ago

On 2.15.x we added complete support of CAggs using time bucket with origin and/or offset, but we restrict the creating when the bucked size is variable due to some uncertaing regarding monthly buckets.

When bucketing by month we always align with the beginning of the month even defining an origin with day component. So to be consistent with the current implementation we'll not change this behavior and allow it to be used in Continuous Aggregates.

Disable-check: force-changelog-file

Notes

In order to make less painful the manual backport we also backported #6939

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 88.00000% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (2.15.x@c342181). Learn more about missing BASE report.

Files Patch % Lines
tsl/src/continuous_aggs/common.c 89.23% 0 Missing and 7 partials :warning:
tsl/src/continuous_aggs/create.c 80.00% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## 2.15.x #7011 +/- ## ========================================= Coverage ? 80.97% ========================================= Files ? 198 Lines ? 37322 Branches ? 9737 ========================================= Hits ? 30223 Misses ? 3195 Partials ? 3904 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.