timescale / timescaledb

An open-source time-series SQL database optimized for fast ingest and complex queries. Packaged as a PostgreSQL extension.
https://www.timescale.com/
Other
16.8k stars 852 forks source link

Prevent locking compressed tuples #7046

Closed svenklemm closed 1 week ago

svenklemm commented 1 week ago

Error out when we detect that a scan is trying to lock compressed tuple. This does not block lock tuples on compressed hypertables in general but only errors for queries where actual compressed tuples would be returned. This will allow queries on compressed hypertables where compressed tuples are filtered by other means e.g. chunk exclusion or query constraints. Not blocking this will produce a very misleading Could not read block 0 error.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.80%. Comparing base (59f50f2) to head (d101adc). Report is 216 commits behind head on main.

Files Patch % Lines
tsl/src/nodes/decompress_chunk/exec.c 66.66% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7046 +/- ## ========================================== + Coverage 80.06% 81.80% +1.73% ========================================== Files 190 200 +10 Lines 37181 37232 +51 Branches 9450 9702 +252 ========================================== + Hits 29770 30456 +686 + Misses 2997 2876 -121 + Partials 4414 3900 -514 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.