search

timescale / timescaledb

An open-source time-series SQL database optimized for fast ingest and complex queries. Packaged as a PostgreSQL extension.
https://www.timescale.com/
Other
16.8k stars 852 forks source link

Fix handling for multiple unique index in compressed INSERT #7061

Closed svenklemm closed 6 days ago

svenklemm commented 1 week ago

Adjust compressed_insert_key_columns to correctly handle multiple unique indexes. This patch changes the function to no longer combine the columns from multiple indexes but instead only return intersecting columns from all the unique indexes. This patch also fixes a couple comments in that function.

Disable-check: commit-count

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.75%. Comparing base (59f50f2) to head (e575c4c). Report is 227 commits behind head on main.

Files Patch % Lines
tsl/src/compression/compression.c 72.72% 1 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7061 +/- ## ========================================== + Coverage 80.06% 81.75% +1.68% ========================================== Files 190 200 +10 Lines 37181 37298 +117 Branches 9450 9725 +275 ========================================== + Hits 29770 30493 +723 + Misses 2997 2897 -100 + Partials 4414 3908 -506 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.