search

timescale / timescaledb

An open-source time-series SQL database optimized for fast ingest and complex queries. Packaged as a PostgreSQL extension.
https://www.timescale.com/
Other
16.8k stars 852 forks source link

Don't use index column names #7069

Closed svenklemm closed 5 days ago

svenklemm commented 6 days ago

We must never use index column names to try to match relation column names between different relations as index column names are independent of relation column names and can get out of sync due to column renames.

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.78%. Comparing base (59f50f2) to head (3862ddc). Report is 230 commits behind head on main.

Files Patch % Lines
tsl/src/compression/compression.c 78.57% 1 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7069 +/- ## ========================================== + Coverage 80.06% 81.78% +1.71% ========================================== Files 190 200 +10 Lines 37181 37350 +169 Branches 9450 9740 +290 ========================================== + Hits 29770 30545 +775 + Misses 2997 2888 -109 + Partials 4414 3917 -497 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

akuzm commented 6 days ago

Should we add some test for this?

svenklemm commented 6 days ago

Should we add some test for this?

Hmm we could scramble all the index column names in regresscheck-shared