timescale / timescaledb

An open-source time-series SQL database optimized for fast ingest and complex queries. Packaged as a PostgreSQL extension.
https://www.timescale.com/
Other
16.8k stars 852 forks source link

Add logs in the recompression code path #7070

Closed nikkhils closed 4 days ago

nikkhils commented 6 days ago

We added a few diagnostic log messages in the compression/decompression code paths some time ago and they have been useful in identifying hotspots in the actual activities. Adding a few more for recompression now. The row_compressor_append_sorted_rows function which is also used in recompression is already logged so we need just a few log messages here.

Disable-check: force-changelog-file

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.77%. Comparing base (59f50f2) to head (23552b6). Report is 228 commits behind head on main.

Files Patch % Lines
tsl/src/compression/api.c 75.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7070 +/- ## ========================================== + Coverage 80.06% 81.77% +1.70% ========================================== Files 190 200 +10 Lines 37181 37301 +120 Branches 9450 9729 +279 ========================================== + Hits 29770 30502 +732 + Misses 2997 2888 -109 + Partials 4414 3911 -503 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fabriziomello commented 6 days ago

@nikkhils wondering if we should use LOCK_DEBUG in our cloud to be able to properly trace locks (https://www.postgresql.org/docs/current/runtime-config-developer.html#GUC-TRACE-LOCKS)

nikkhils commented 4 days ago

@nikkhils wondering if we should use LOCK_DEBUG in our cloud to be able to properly trace locks (https://www.postgresql.org/docs/current/runtime-config-developer.html#GUC-TRACE-LOCKS)

@fabriziomello that will be too chatty if we enable it by default. We only need specific interesting data points in certain activities.