timescale / timescaledb

An open-source time-series SQL database optimized for fast ingest and complex queries. Packaged as a PostgreSQL extension.
https://www.timescale.com/
Other
17.94k stars 883 forks source link

Refactor option to skip compressed in Hypercore TAM scans #7454

Closed erimatnor closed 5 days ago

erimatnor commented 1 week ago

Replace the scankey flag used to skip compressed data when starting a Hypercore scan with a function that sets this option on the scan descriptor. Internally, use the scan flags instead of scankey flags to convey this setting.

Overloading scankey flags was not ideal since this is supposed to be per-column settings and not overall scan settings.

Note that it is possible to set the scan flags when calling the TAM's beginscan callback, but the table_beginscan() wrapper does not expose flags and instead there's a separate function for each flag settings. Hypercore could define its own beginscan function to do the same, but this is left for the future.

Disable-check: force-changelog-file

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.11%. Comparing base (59f50f2) to head (211a075). Report is 611 commits behind head on main.

Files with missing lines Patch % Lines
tsl/src/hypercore/hypercore_handler.c 90.90% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #7454 +/- ## ========================================== + Coverage 80.06% 82.11% +2.04% ========================================== Files 190 230 +40 Lines 37181 43087 +5906 Branches 9450 10824 +1374 ========================================== + Hits 29770 35380 +5610 - Misses 2997 3395 +398 + Partials 4414 4312 -102 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: