timescale / tobs

tobs - The Observability Stack for Kubernetes. Easy install of a full observability stack into a k8s cluster with Helm charts.
Apache License 2.0
561 stars 61 forks source link

Disabling kube-prometheus-stack causes a number of issues #526

Closed nhudson closed 2 years ago

nhudson commented 2 years ago

If you disable kube-state-metrics in values.yaml tobs will incorrectly generate CR's that depend on kube-state-metrics to be enabled.

We need to be able to correctly handle the situation where aspects of the tobs Helm chart is disabled and carry those across all dependent Helm charts.

nhudson commented 2 years ago

I am going to close this as I believe there should be an assumption that either kube-prometheus-stack or the prometheus-operator is installed somewhere on your system and thus will work with both ServiceMonitor and PrometheusRule CRD's.