timescale / tobs

tobs - The Observability Stack for Kubernetes. Easy install of a full observability stack into a k8s cluster with Helm charts.
Apache License 2.0
560 stars 61 forks source link

Do not render secret if grafana envFromSecret is set #600

Closed nhudson closed 1 year ago

nhudson commented 1 year ago

What this PR does / why we need it

Disable the rendering of the -grafana-db Secret if they are provided by supplying another Secret in which they already exist.

Which issue this PR fixes

Special notes for your reviewer

This will assume if kube-prometheus-stack.grafana.envFromSecret exists then it will provide the correct env variables needed. While the documentation is updated to reflect that setting this will ignore the Secret, we might need to provide more care and look for specific env variables.

Checklist