timescale / tobs

tobs - The Observability Stack for Kubernetes. Easy install of a full observability stack into a k8s cluster with Helm charts.
Apache License 2.0
560 stars 61 forks source link

Helm doesn't uninstall open telemetry collector #601

Closed mathisve closed 1 year ago

mathisve commented 1 year ago

What happened?

I'm not sure if this is a bug or if this is intentional, but when you deploy tobs using helm with the opentelemetry-operator enabled, it doesn't delete the opentelemetry-operator and pods associated with the otel operator.

Did you expect to see something different?

I expect to see the otel related resources (minus CRDs) to be deleted when uninstalling tobs using helm.

How to reproduce it (as minimally and precisely as possible):

helm install tobs timescale/tobs -n tobs --set opentelemtry-operator.enabled=true

helm ls -n tobs
# NAME    NAMESPACE       REVISION        UPDATED                                 STATUS          CHART           APP VERSION
# tobs    tobs            1               2022-10-06 13:29:27.823741 -0600 MDT    deployed        tobs-14.13.1               

helm uninstall tobs -n tobs

kubectl get pods -n tobs
# NAME                                            READY   STATUS    RESTARTS   AGE
# tobs-opentelemetry-collector-74bcfbcfcd-d5rmq   1/1     Running   0          3m3s

Environment

nhudson commented 1 year ago

@mathisve this is an issue with Helm from what we can tell. The issue got closed somehow, but it's described here #365 specifically this comment https://github.com/timescale/tobs/issues/365#issuecomment-1171152080

The docs indicate specific steps you need to follow to remove everything from the namespace https://github.com/nhudson/tobs/blob/main/chart/README.md#uninstall

mathisve commented 1 year ago

Ah, I see.

Sorry for not seeing the already existing issue!

alejandrodnm commented 1 year ago

Hi @mathisve I'm closing this. Feel free to reopen it if the need arise. Cheers.