Closed filipecosta90 closed 4 years ago
Great catch -- looks like the tests need to be slightly updated.
Ping @filipecosta90 . Happy to merge once tests pass.
Hi there, sorry for the delay. Will fix still today :)
Merging #110 into master will increase coverage by
0.33%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #110 +/- ##
==========================================
+ Coverage 69.26% 69.59% +0.33%
==========================================
Files 103 104 +1
Lines 5723 5812 +89
==========================================
+ Hits 3964 4045 +81
- Misses 1684 1689 +5
- Partials 75 78 +3
Impacted Files | Coverage Δ | |
---|---|---|
query/http.go | 93.93% <100%> (+0.18%) |
:arrow_up: |
...d/tsbs_generate_queries/databases/influx/devops.go | 100% <100%> (ø) |
:arrow_up: |
...d/tsbs_generate_queries/databases/influx/common.go | 85.71% <100%> (+0.52%) |
:arrow_up: |
internal/inputs/generator_data.go | 88.81% <0%> (-1.19%) |
:arrow_down: |
internal/inputs/utils.go | 78.26% <0%> (ø) |
:arrow_up: |
cmd/tsbs_generate_data/serialize/akumuli.go | 92.85% <0%> (ø) |
|
internal/inputs/generator_queries.go | 73.17% <0%> (+0.16%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1d12206...e755d57. Read the comment docs.
Ping @filipecosta90 . Happy to merge once tests pass.
@RobAtticus done
Thanks! Merged
overall description
solves #109 [fix] fixed cpu-max-all-* for influx. [add] added influxql to --print-responses option within query runner
If you guys compare timescale's and influx's results for cpu-max-all-1 and cpu-max-all-8 queries, you will notice that there is a wrong group by time clause on influx ( group by time(1m) should be group by time(1h). The changes in this PR fix the issue and improvement the resultset output for influx ( so that we can easily check this type of error.
current master cpu-max-all-1 ( notice group by minute )
after fix cpu-max-all-1 ( notice group by hour )