toddlipcon commented 4 years ago

Previously, every worker thread created its own HTTP Client instance which shared the underlying go default HTTP transport. The default transport limits its max idle connections per host to 2.

This meant that, when running with --workers > 2, there would be moments in time with more thn two idle connections and connections would be dropped and need to be reconnected. Without this change, a run of many thousand queries with 8 workers would reconnect ~1000 times. With the change, it only connects once per worker.

CLAassistant commented 4 years ago

All committers have signed the CLA.

codecov-io commented 4 years ago

Codecov Report

Merging #118 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   69.59%   69.59%           
=======================================
  Files         104      104           
  Lines        5812     5812           
=======================================
  Hits         4045     4045           
  Misses       1689     1689           
  Partials       78       78

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f1523d...55f312d. Read the comment docs.

timescale / tsbs

Fix HTTP client keepalive for influx #118

Codecov Report