search

timescale / tsbs

Time Series Benchmark Suite, a tool for comparing and evaluating databases for time series data
MIT License
1.26k stars 299 forks source link

Minor fixes #125

Open AlekseyKanaev opened 4 years ago

AlekseyKanaev commented 4 years ago

I made fixes tipped by linter.

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: AlekseyKanaev
:x: alex

alex seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

codecov-commenter commented 3 years ago

Codecov Report

Merging #125 (635eaa7) into master (1ac5e93) will not change coverage. The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   65.25%   65.25%           
=======================================
  Files         145      145           
  Lines        5966     5966           
=======================================
  Hits         3893     3893           
  Misses       1960     1960           
  Partials      113      113
Impacted Files Coverage Δ
cmd/tsbs_load_cratedb/processor.go 0.00% <0.00%> (ø)
pkg/targets/clickhouse/processor.go 1.66% <0.00%> (ø)
...bs_generate_queries/databases/clickhouse/devops.go 100.00% <100.00%> (ø)
...s_generate_queries/databases/timescaledb/devops.go 98.42% <100.00%> (ø)
pkg/targets/mongo/serializer.go 88.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1ac5e93...635eaa7. Read the comment docs.

AlekseyKanaev commented 3 years ago

License signing is blocked because my previous commits are not recognized by github as my own. I don't know how to fix it.

jonatas commented 2 years ago

@AlekseyKanaev you need to rewrite your commits. You can use git rebase -i to interactively rebase your PR and it will allow you to rewrite/squash commits together. Check a few options here.